Skip to content

/ pysrt

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open(): don't use universal 'U' mode #80

Merged
merged 1 commit into from Jan 20, 2020
Merged

open(): don't use universal 'U' mode #80

merged 1 commit into from Jan 20, 2020

Conversation

@vstinner
Copy link
Contributor

vstinner commented Jan 20, 2020

The open() 'U' mode has been removed from Python 3.9.
@vstinner
open(): don't use universal 'U' mode
Loading status checks…
17e1f58 
The open() 'U' mode has been removed from Python 3.9.
@vstinner
Copy link
Contributor Author

vstinner commented Jan 20, 2020

Tests still pass on Python 2.7 and 3.9: I tested manually on Linux.
@byroot byroot merged commit 5465f2f into byroot:master Jan 20, 2020
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@byroot
Copy link
Owner

byroot commented Jan 20, 2020

Thanks.
@vstinner
Copy link
Contributor Author

vstinner commented Jan 20, 2020

FASTEST MERGE EVER! Thank you :-) That's was blazing fast!
@vstinner vstinner deleted the vstinner:py39 branch Jan 20, 2020
@byroot
Copy link
Owner

byroot commented Jan 20, 2020

Happy accident I guess.

If it's outright broken on new versions I'll see about cutting a new release.
@byroot
Copy link
Owner

byroot commented Jan 20, 2020

I'll see about cutting a new release.

Ok, I had a bit of a hard time figuring out the new tools, but in the end 1.1.2 is out.

Since you are up to date with Python (whereas I'm really not anymore), would be nice if you could confirm me I didn't bork the release.
@vstinner
Copy link
Contributor Author

vstinner commented Jan 20, 2020

Oh, I forgot the link to the Fedora downstream issue: https://bugzilla.redhat.com/show_bug.cgi?id=1793011
@vstinner
Copy link
Contributor Author

vstinner commented Jan 22, 2020

Since you are up to date with Python (whereas I'm really not anymore), would be nice if you could confirm me I didn't bork the release.

The Fedora package has been updated with success: https://bugzilla.redhat.com/show_bug.cgi?id=1793011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@vstinner @byroot
You can’t perform that action at this time.