Skip to content

/ nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soapysdr: add as python module #76898

Merged
merged 1 commit into from Jan 5, 2020
Merged

soapysdr: add as python module #76898

merged 1 commit into from Jan 5, 2020

Conversation

@markuskowa
Copy link
Member

@markuskowa markuskowa commented Jan 3, 2020 •
edited

Motivation for this change

Use "toPythonModule" function to make python interface available.
So far the python interface was not properly exposed via nixpkgs (closes #76808)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sbourdeauducq
@markuskowa markuskowa requested review from FRidh and jonringer as code owners Jan 3, 2020
@ofborg ofborg bot added the 6.topic: python label Jan 3, 2020
@FRidh
FRidh reviewed Jan 3, 2020
View changes
pkgs/applications/radio/soapysdr/default.nix Outdated Show resolved Hide resolved
@markuskowa
soapysdr: add as python module
Verified
This commit was signed with a verified signature.
markuskowa
GPG key ID: D865C8A91D7025EB Learn about signing commits
Loading status checks…
4097ffc 
Use "toPythonModule" function to make python interface available.
@markuskowa markuskowa force-pushed the markuskowa:fix-soapysdr branch from b69cf18 to 4097ffc Jan 3, 2020
@markuskowa markuskowa requested a review from sbourdeauducq Jan 4, 2020
@sbourdeauducq
sbourdeauducq approved these changes Jan 5, 2020
View changes
Copy link
Contributor

@sbourdeauducq sbourdeauducq left a comment

Works on my machine.
Thanks!
@markuskowa markuskowa merged commit 87021d3 into NixOS:master Jan 5, 2020
16 checks passed
16 checks passed
soapysdr on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
soapysdr on aarch64-linux Success
Details
soapysdr on x86_64-linux Success
Details
@markuskowa markuskowa deleted the markuskowa:fix-soapysdr branch Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@sbourdeauducq sbourdeauducq

@jonringer jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer 6.topic: python 8.has: package (new)
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

soapysdr: Python binding cannot be used
3 participants
@markuskowa @sbourdeauducq @FRidh
You can’t perform that action at this time.