Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-36508: python-config don't export LINKFORSHARED (GH-12661) #12748

Merged
merged 1 commit into from Apr 16, 2019
Merged

[3.7] bpo-36508: python-config don't export LINKFORSHARED (GH-12661) #12748

merged 1 commit into from Apr 16, 2019

Conversation

@miss-islington
Copy link

miss-islington commented Apr 9, 2019 •
edited by bedevere-bot

python-config --ldflags no longer includes flags of the LINKFORSHARED
variable. The LINKFORSHARED variable must only be used to build
executables.
(cherry picked from commit e65f01f)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue36508
@vstinner @miss-islington
bpo-36508: python-config don't export LINKFORSHARED (GH-12661)
Loading status checks…
93b0a54 
python-config --ldflags no longer includes flags of the LINKFORSHARED
variable. The LINKFORSHARED variable must only be used to build
executables.
(cherry picked from commit e65f01f)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot bedevere-bot mentioned this pull request Apr 9, 2019
Merged
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Apr 9, 2019

The backport is straightfoward, but I would prefer to see the buildbot runnings on it before merging it into 3.7.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Apr 9, 2019

@vstinner: Status check is done, and it's a success ✅ .
@vstinner vstinner merged commit cd46b09 into python:3.7 Apr 16, 2019
6 checks passed
6 checks passed
Azure Pipelines PR #20190409.35 succeeded
Details
bedevere/issue-number Issue number 36508 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington miss-islington deleted the miss-islington:backport-e65f01f-3.7 branch Apr 16, 2019
@thp thp mentioned this pull request Jun 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
4 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.