Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Use LibGit2Sharp v0.24.0 + fix crash when viewing PRs #1330
Conversation
Use the latest "stable" version of LibGit2Sharp.
Somehow putting the `repo` object in a `using` avoids the following issue: #1306
|
I haven't been able to this build crash using VS 2017 and the Avalonia solution. Went up and down the list of PRs and nothing. Please beat on it and see if you can make it crash! |
|
this is looking great to me. tested in both VS2015 and VS2017 with multiple repositories and haven't experienced a crash when viewing PRs. |
|
LGTM! Tried it and don't seem to be getting the crashes any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The crash when viewing PRs was still happening in the GHfVS v2.3.5 bugfix release. This PR moves back to LibGit2Sharp v0.24.0 (because moving to v0.23.1 didn't fix it).
I've cherry-picked the fix from #1311. This wrapps the
Repositoryobject in ausingstatement. This appears to fix the issue, but I'm not convinced the fix is anything to do with disposing theRepositoryobject (it can crash before the object has been disposed).I'm not sure why the fix works, but it doesn't harm anything and it's worth getting out ASAP while we're working for a more concrete solution.
Fixes #1306