Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by Name #85

Open
claudiobernasconi opened this issue Jan 7, 2020 · 6 comments
Open

Sort by Name #85

claudiobernasconi opened this issue Jan 7, 2020 · 6 comments

Comments

@claudiobernasconi
Copy link

@claudiobernasconi claudiobernasconi commented Jan 7, 2020

It might be useful to sort the channels by name (within a category). I believe the current order is random and does not offer any benefit to alphabetical order.

What are your opinions on this? I'd create a PR if that is what you'd like to have.

@sukhchainn

This comment has been minimized.

Copy link

@sukhchainn sukhchainn commented Jan 9, 2020

I'm currently working on refactoring the entire list. I will create a grep command to order the list alphabetically or it can be done in JavaScript too. Please tell me which one you are comfortable in.

I would recommend that using gawk is much more efficient, but since grep and bash are bundled with Git on windows and they are preinstalled on Linux and Mac, using them is the first choice here. But I would like to hear your opinion too.

@claudiobernasconi

This comment has been minimized.

Copy link
Author

@claudiobernasconi claudiobernasconi commented Jan 9, 2020

You're basically talking about an automated solution to the issue I pointed out? I'm okay with however this gets done, but I believe it should be done. I'm sure the owner of the repo would be okay with you making a script to do that.

@sukhchainn

This comment has been minimized.

Copy link

@sukhchainn sukhchainn commented Jan 15, 2020

@claudiobernasconi Automation script is still far but I have sorted the list manually now and the pull request which contains the changes is

#69

@ErikCH

This comment has been minimized.

Copy link
Owner

@ErikCH ErikCH commented Jan 18, 2020

I like the idea of automating this somewhow so the list is alphabetical. With that said, I'm not sure exactly how this would work. Unless it was some sort of action that could be run on each PR... I don't know... The problem is, that new contributors are NOT going to be able to put every new channel in alphabetically into the list... and I don't want to have to do it manually for each new PR.

@sukhchainn

This comment has been minimized.

Copy link

@sukhchainn sukhchainn commented Jan 18, 2020

@ErikCH you don't have to worry about it. The script is mostly non-interactive which means you don't have to interact with it to get the basic tasks done. The contributor would just need to create a "new.md" file and in that file write all the new entries under the correct heading. The script will match the corresponding heading and add the new entries in that section.

I can understand your concerns, but you don't have to worry about anything. I am following UGU(User Group Universality) principals here which are considered best practices for CLI tools.

@anuraghazra

This comment has been minimized.

Copy link

@anuraghazra anuraghazra commented Feb 2, 2020

We can run sorting script in each PR with Github Actions and update the contents of the readme.md file automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.