Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI example mouse clicks won't work when isometric_rpg example playerEntity is enabled #952

Open
jkalkhof opened this issue Oct 1, 2018 · 4 comments

Comments

@jkalkhof
Copy link

@jkalkhof jkalkhof commented Oct 1, 2018

OS platform / Browser

Windows 10/Chrome Version 69.0.3497.100 (Official Build) (64-bit)

melonJS version

master branch - 10/1/2018 - melonjs 6.2.0

Bug description

UI example mouse clicks won't work with simulation_rpg example

Steps to reproduce the bug

I have put in a pull request 951 - code which reproduces the problem.
(see examples/isometric_rpg_ui)
#951

change to line 43 of game.js:
me.pool.register("mainPlayer", game.PlayerEntity);
to
me.pool.register("mainPlayer", me.Entity);
will prevent the conflict of playerEntity affecting the UI mouse clicks.

Console log Extract

-no errors in log

@obiot
Copy link
Member

@obiot obiot commented Oct 3, 2018

oh... weird & interesting ! thanks for the report I will have a look at it.

@obiot
Copy link
Member

@obiot obiot commented Oct 3, 2018

weird because there are at least a couple of isometric project going on those days, and none of the developers reported any issue, so maybe it's just a bug in the isometric example, let's hope for it :)

@jkalkhof
Copy link
Author

@jkalkhof jkalkhof commented Oct 4, 2018

Looks like I found a clue:
if I disable line 25 of UIContainer.js the mouse clicks work:

        // causes conflict with game.PlayerEntity
        // this.floating = true;

I'm not sure why floating feature of me.Container (me.Renderable) would cause a problem.

@obiot
Copy link
Member

@obiot obiot commented Oct 27, 2018

@jkalkhof apologies as I did not have the time yet to go through this one, however I just pushed a few commits with some regression following the viewport change on the master branch.

it would really be great if you could update your current branch and see if the problem is still there :)

thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.