Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUnhandled exception when BeatMods website is unreachable #3
Comments
This comment has been minimized.
This comment has been minimized.
|
I guess this got fixed in commit d3b97d0 for release v1.0.8 and later? btw - Thanks for your work. |
This comment has been minimized.
This comment has been minimized.
|
I wouldn't say it's entirely fixed, but it's somewhat fixed. |
This comment has been minimized.
This comment has been minimized.
|
I fixed that in the old installer, I'll give a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tested with v.1.0.7
There is an unhandled exception when changing to the Mods tab while the BeatMods website is unreachable and returning HTTP error 502, which causes the application to crash. Any other HTTP error code might have the same result.
It would probably be better to catch that exception and inform the user, that the application was not able to reach the BeatMods website. Maybe even including the returned HTTP error code or any other error returned by the HttpWebRequest library.
Screenshot with the error message attached:
My local system language is German. Second and third line should translate to:
"System.Net.WebException: The remote server returned an error: (502) Invalid Gateway."