Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use local workers when there is no settings.yaml #142

Merged
merged 4 commits into from Jan 15, 2020

Conversation

@pablogsal
Copy link
Member

pablogsal commented Jan 7, 2020

When working locally, we need to substitute the workers by LocalWorker so we can trigger builds as desired locally and also deactivate auth (so we don't need to log into the local instance using GitHub).

@pablogsal pablogsal requested a review from zware Jan 7, 2020
master/custom/workers.py Outdated Show resolved Hide resolved
master/custom/workers.py Show resolved Hide resolved
master/master.cfg Outdated Show resolved Hide resolved
@pablogsal
Copy link
Member Author

pablogsal commented Jan 7, 2020

Will update the PR soon :)

Thanks for the review @zware !

@pablogsal pablogsal requested a review from zware Jan 14, 2020
@zware
zware approved these changes Jan 15, 2020
Copy link
Member

zware left a comment

One final nit, but I think this is fine.

@@ -11,7 +11,8 @@ class CPythonWorker:

def __init__(self, settings, name,
tags=None, branches=None,
parallel_builders=None, parallel_tests=None):
parallel_builders=None, parallel_tests=None,
local=False):

This comment has been minimized.

@zware

zware Jan 15, 2020

Member

This new parameter doesn't seem to be used.

master/custom/workers.py Show resolved Hide resolved
@pablogsal pablogsal merged commit 2509a12 into python:master Jan 15, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pablogsal pablogsal deleted the pablogsal:easier_local branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.