Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better version identifier #333

Closed
myint opened this issue Aug 10, 2014 · 3 comments
Closed

Better version identifier #333

myint opened this issue Aug 10, 2014 · 3 comments
Labels
Milestone

Comments

@myint
Copy link

@myint myint commented Aug 10, 2014

Currently, if you install the GitHub version of bpython, the version is identified as mercurial. This has two downsides. The first obvious, but the second is it makes pip list --outdated act a bit strange. It will always show the same thing no matter how up to date your GitHub version is:

$ pip list --outdated
bpython (Current: mercurial Latest: 0.13.1)

It would be nice if bpython used a versioning scheme compatible with distutils.version.StrictVersion (like 0.14a0 assuming that is what the master branch represents):

    class StrictVersion(Version)
     |  Version numbering for anal retentives and software idealists.
     |  Implements the standard interface for version number classes as
     |  described above.  A version number consists of two or three
     |  dot-separated numeric components, with an optional "pre-release" tag
     |  on the end.  The pre-release tag consists of the letter 'a' or 'b'
     |  followed by a number.  If the numeric components of two version
     |  numbers are equal, then one with a pre-release tag will always
     |  be deemed earlier (lesser) than one without.
     |
     |  The following are valid version numbers (shown in the order that
     |  would be obtained by sorting according to the supplied cmp function):
     |
     |      0.4       0.4.0  (these two are equivalent)
     |      0.4.1
     |      0.5a1
     |      0.5b3
     |      0.5
     |      0.9.6
     |      1.0
     |      1.0.4a3
     |      1.0.4b1
     |      1.0.4
@ikanobori
Copy link
Contributor

@ikanobori ikanobori commented Aug 10, 2014

I'll take a look at this tomorrow at work. Thanks for the note 👍

In general our master branch is the next version, in this case 0.14. I'll check if the pip listing understands something like nightly or a revision id.

@thomasballinger thomasballinger added this to the 0.14 milestone Sep 16, 2014
@thomasballinger
Copy link
Member

@thomasballinger thomasballinger commented Oct 18, 2014

+1 on this - now that I've added a version banner I'm reminded of this every time I open bpython.

@sebastinas
Copy link
Contributor

@sebastinas sebastinas commented Oct 27, 2014

As said on IRC, we could use 0.14a$(git describe --tags | sed 's/-/ /g' | awk '{ print $3 }') for master. I'm not sure if this integrates well in our workflow, though. There is also the option to use https://github.com/warner/python-versioneer to get this done automatically.

@sebastinas sebastinas closed this in 25838bf Jan 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.