Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-core.yml should use `dotnet test` if tests are to be run #208

Open
lee-11 opened this issue Nov 19, 2019 · 2 comments
Open

dotnet-core.yml should use `dotnet test` if tests are to be run #208

lee-11 opened this issue Nov 19, 2019 · 2 comments

Comments

@lee-11
Copy link

@lee-11 lee-11 commented Nov 19, 2019

Looking at the dotnet-core.yml Activity, the description of it on the listing page states that it "builds and tests" a .Net Core project. And that's the Right Thing, based on what the other listed Activities do.

However, in the repo the code only does a dotnet build which will not run tests. The full command should instead be dotnet test --configuration Release which will build and test the project. Small but important difference.

@phantommyk

This comment has been minimized.

Copy link

@phantommyk phantommyk commented Jan 11, 2020

ad4g:master

@phantommyk

This comment has been minimized.

Copy link

@phantommyk phantommyk commented Jan 11, 2020

Thanks for you partipation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.