Skip to content

/ raiden

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gevent #5703

Merged
merged 1 commit into from Jan 20, 2020
Merged

Update gevent #5703

merged 1 commit into from Jan 20, 2020

Conversation

@palango
Copy link
Collaborator

@palango palango commented Jan 20, 2020

Ref: gevent/gevent#1515 (comment)
@palango
Update gevent
Loading status checks…
0865f62 
Ref: gevent/gevent#1515 (comment)
@auto-assign auto-assign bot requested a review from rakanalh Jan 20, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 20, 2020 •
edited

Codecov Report

Merging #5703 into develop will increase coverage by 34.8%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5703      +/-   ##
===========================================
+ Coverage    40.98%   75.79%   +34.8%     
===========================================
  Files          131      131              
  Lines        15139    15139              
  Branches      2313     2313              
===========================================
+ Hits          6205    11474    +5269     
+ Misses        8668     3019    -5649     
- Partials       266      646     +380
Flag Coverage Δ
#integration 68.33% <ø> (+33.25%) ⬆️
#unit 55.73% <ø> (+17.47%) ⬆️
Impacted Files Coverage Δ
raiden/transfer/state.py 88.36% <0%> (+1.72%) ⬆️
raiden/settings.py 100% <0%> (+3.09%) ⬆️
raiden/exceptions.py 100% <0%> (+3.57%) ⬆️
raiden/messages/withdraw.py 92.85% <0%> (+3.57%) ⬆️
raiden/log_config.py 80.91% <0%> (+3.81%) ⬆️
raiden/transfer/mediated_transfer/events.py 100% <0%> (+3.94%) ⬆️
raiden/ui/cli.py 36.55% <0%> (+4.65%) ⬆️
raiden/messages/healthcheck.py 94.44% <0%> (+5.55%) ⬆️
raiden/ui/app.py 29.78% <0%> (+5.67%) ⬆️
raiden/api/objects.py 81.25% <0%> (+6.25%) ⬆️
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd2126...0865f62. Read the comment docs.
@rakanalh
rakanalh reviewed Jan 20, 2020
View changes
requirements/requirements-ci.txt
@@ -57,7 +57,7 @@ flask-cors==3.0.8
flask-restful==0.3.7
flask==1.0.3
frozendict==1.2
gevent==1.3.7
gevent==1.5a3

This comment has been minimized.

Sign in to view
@rakanalh

rakanalh Jan 20, 2020
Contributor

Is it a good idea to upgrade to an alpha version of 1.5? why not choose the latest 1.4.x?

This comment has been minimized.

Sign in to view
@palango

palango Jan 20, 2020
Author Collaborator

It it what was proposed in the reference.
@hackaugusto
hackaugusto approved these changes Jan 20, 2020
View changes
@hackaugusto hackaugusto merged commit 65bcc18 into raiden-network:develop Jan 20, 2020
17 checks passed
17 checks passed
ci/circleci: build-docs-3.7 Your tests passed on CircleCI!
Details
ci/circleci: checkout Your tests passed on CircleCI!
Details
ci/circleci: finalize Your tests passed on CircleCI!
Details
ci/circleci: lint-3.7 Your tests passed on CircleCI!
Details
ci/circleci: prepare-python-linux-3.7 Your tests passed on CircleCI!
Details
ci/circleci: prepare-system-linux Your tests passed on CircleCI!
Details
ci/circleci: smoketest-matrix-development-geth-3.7 Your tests passed on CircleCI!
Details
ci/circleci: smoketest-matrix-development-parity-3.7 Your tests passed on CircleCI!
Details
ci/circleci: smoketest-matrix-production-geth-3.7 Your tests passed on CircleCI!
Details
ci/circleci: test-fuzz-3.7 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-matrix-geth-3.7 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-matrix-parity-3.7 Your tests passed on CircleCI!
Details
ci/circleci: test-mocked-3.7 Your tests passed on CircleCI!
Details
ci/circleci: test-unit-3.7 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing ffd2126...0865f62
Details
codecov/project 75.79% (+34.8%) compared to ffd2126
Details
license/cla Contributor License Agreement is signed.
Details
@palango palango deleted the palango:update-gevent branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakanalh rakanalh

@hackaugusto hackaugusto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@palango @rakanalh @hackaugusto
You can’t perform that action at this time.