Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdsMediaSource isn't documented in the developer guide. #5105

Closed
BetweenTwoBits opened this issue Nov 14, 2018 · 5 comments
Closed

AdsMediaSource isn't documented in the developer guide. #5105

BetweenTwoBits opened this issue Nov 14, 2018 · 5 comments
Assignees

Comments

@BetweenTwoBits
Copy link
Contributor

@BetweenTwoBits BetweenTwoBits commented Nov 14, 2018

The developer guide has a wonderful section on MediaSources, but doesn't mention the AdsMediaSource. Having docs around the benefits and use cases would be immensely useful.

@tonihei
Copy link
Contributor

@tonihei tonihei commented Nov 14, 2018

Good point. I'll mark this as an enhancement to add a section about ad playback in general.

@ajonno
Copy link

@ajonno ajonno commented Jan 19, 2020

I was trying to understand how to use AdsMediaSource today as we are currently building a large podcast app (1M+ users from our existing user base) but no such luck :-( Can you point me to some info/examples etc ? Many thanks

@andrewlewis
Copy link
Contributor

@andrewlewis andrewlewis commented Jan 19, 2020

The original blog post about the IMA extension still has some useful information and may be a starting point. The ExoPlayer demo app also integrates with the IMA extension so you could take a look at that as well. Resolving this issue by adding proper documentation to the developer guide is still work in progress I'm afraid.

Edit: given your issue #6891 is a different use case from the IMA extension, this answer isn't relevant. Please have a look at #6814 which I think does what you need.

@ojw28
Copy link
Contributor

@ojw28 ojw28 commented Nov 15, 2020

There is a section on ad insertion now, here.

@ojw28 ojw28 closed this Nov 15, 2020
@BetweenTwoBits
Copy link
Contributor Author

@BetweenTwoBits BetweenTwoBits commented Nov 17, 2020

Thank you for following up @ojw28!

@google google locked and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants