Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple values for the git.path setting #85734

Closed
CMDMC12 opened this issue Nov 28, 2019 · 7 comments · Fixed by #85954
Closed

Support multiple values for the git.path setting #85734

CMDMC12 opened this issue Nov 28, 2019 · 7 comments · Fixed by #85954
Assignees
Labels
feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded

Comments

@CMDMC12
Copy link

CMDMC12 commented Nov 28, 2019

I use VSCode in three different places; my home computer, my work computer, and as a portable version I carry on a drive when I need to use a machine that doesn't have it.

I use an extension to keep my settings synced up between editors, and the only issue I've encountered so far is that the git path doesn't match between any of them. On my home machine I have it installed to C of course, work likes to be funny and install it on A, and for the one on my drive I have a relative path set so that no matter what letter my drive gets, that VSCode can always find git.

I already attempted to use an array myself just to see if it'd work:
"git.path": ["C:\\Program Files\\Git\\bin\\git.exe", "A:\\Git\\bin\\git.exe", "..\\..\\Git\\bin\\git.exe"],

But VSCode reads it as one entire value.

What I'd like is for it to recognize it as an array and then try each path in order until it finds Git or runs out of paths.

@whizsid
Copy link
Contributor

whizsid commented Nov 28, 2019

It is better to create an issue in https://github.com/shanalikhan/code-settings-sync extension repo with requesting the settings ignore feature.

@whizsid
Copy link
Contributor

whizsid commented Nov 28, 2019

Hy @CMDMC12

You can ignore certain settings in settings.json or keybindings.json by using the @sync-ignore pragma.

// settings.json

{
// @sync-ignore
"window.zoomLevel": "1", /* won't upload to gist */
}

Read More >>

@joaomoreno joaomoreno added feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Dec 2, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Dec 2, 2019

This is a good feature request, please feel free to submit a PR.

@joaomoreno joaomoreno added the git GIT issues label Dec 2, 2019
@joaomoreno joaomoreno added this to the Backlog milestone Dec 2, 2019
@CMDMC12
Copy link
Author

CMDMC12 commented Dec 4, 2019

Hy @CMDMC12

You can ignore certain settings in settings.json or keybindings.json by using the @sync-ignore pragma.

// settings.json

{
// @sync-ignore
"window.zoomLevel": "1", /* won't upload to gist */
}

Read More >>

Ah, thanks. I must have just seen the section title and completely glossed over it when I was reading through the docs.

@ariveron

This comment has been minimized.

@issacnitin
Copy link
Member

issacnitin commented Mar 1, 2020

This is a good feature request, please feel free to submit a PR.

Raised PR!

@joaomoreno joaomoreno modified the milestones: Backlog, September 2020 Sep 10, 2020
@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Sep 28, 2020
@joaomoreno
Copy link
Member

joaomoreno commented Sep 28, 2020

Verification

The git.path setting now accepts a list of values. The git extension must go through them one by one until it finds a usable git executable.

@connor4312 connor4312 added the verified Verification succeeded label Sep 29, 2020
@joaomoreno joaomoreno added the on-release-notes Issue/pull request mentioned in release notes label Oct 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
7 participants