Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWrong/misleading print when using action menu_download_from_list #626
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Description
Currently, if you use action 4 with option
processFromDB, it will still showProcessing member id from .\list.txt, which is wrong, because it will only process from the DB.The reason is that there is a print at
PixivUtil2/PixivUtil2.py
Line 1714 in 0d09b17
before the conditional in
process_list, which means it will print so regardless ifprocessFromDBis disabled or not.Actually, if you disable
processFromDB, it will also end up printing two relatively redundant messages likebecause there is another print at
PixivUtil2/PixivUtil2.py
Line 367 in 0d09b17
Suggestion
Remove print at PixivUtil2.py#L1714, only print in
process_list. Move conditionals for {tags} cases withinprocess_list. This way, only one line will be printed, and it will without confusion that is is either "from DB" or "from list file", as what the logic actually does.Steps to Reproduce
Versions
You can get this information from executing
PixivUtil2.py --help.master