Skip to content

/ oc

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate --config flag #256

Merged
merged 2 commits into from Jan 22, 2020
Merged

Deprecate --config flag #256

merged 2 commits into from Jan 22, 2020

Conversation

@soltysh
Copy link
Member

@soltysh soltysh commented Jan 14, 2020

This builds on top of #254, to skip the rebase part.
/assign @sallyom
@soltysh
Copy link
Member Author

@soltysh soltysh commented Jan 14, 2020

/hold
for the other PR to merge first.
@soltysh soltysh mentioned this pull request Jan 14, 2020
Closed
@soltysh soltysh mentioned this pull request Jan 15, 2020
Merged
soltysh added 2 commits Jan 14, 2020
@soltysh
bump(*)
Verified
This commit was signed with a verified signature.
soltysh Maciej Szulik
GPG key ID: F15E55D276FA84C4 Learn about signing commits
c43d44e
@soltysh
Generated changes
Verified
This commit was signed with a verified signature.
soltysh Maciej Szulik
GPG key ID: F15E55D276FA84C4 Learn about signing commits
Loading status checks…
82e66a3
@soltysh soltysh force-pushed the soltysh:deprecate_config branch from ae146f2 to 82e66a3 Jan 15, 2020
@openshift-ci-robot openshift-ci-robot added size/XXL and removed size/S labels Jan 15, 2020
@soltysh
Copy link
Member Author

@soltysh soltysh commented Jan 15, 2020

/hold cancel
@soltysh
Copy link
Member Author

@soltysh soltysh commented Jan 15, 2020

/retest
@sallyom
Copy link
Contributor

@sallyom sallyom commented Jan 15, 2020

/lgtm
@openshift-ci-robot
Copy link

@openshift-ci-robot openshift-ci-robot commented Jan 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
1 similar comment
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@soltysh
Copy link
Member Author

@soltysh soltysh commented Jan 15, 2020

/hold
for debugging failures
This was referenced Jan 15, 2020
Merged
Merged
@soltysh
Copy link
Member Author

@soltysh soltysh commented Jan 17, 2020

/retest
2 similar comments
@soltysh
Copy link
Member Author

@soltysh soltysh commented Jan 17, 2020

/retest
@soltysh
Copy link
Member Author

@soltysh soltysh commented Jan 20, 2020

/retest
@soltysh
Copy link
Member Author

@soltysh soltysh commented Jan 20, 2020

/hold cancel
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
17 similar comments
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-merge-robot openshift-merge-robot merged commit ad089cf into openshift:master Jan 22, 2020
9 checks passed
9 checks passed
ci/prow/build-rpms-from-tar Job succeeded.
Details
ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-upgrade Job succeeded.
Details
ci/prow/e2e-cmd Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/rpm-build Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
ci/prow/verify Job succeeded.
Details
tide In merge pool.
Details
@soltysh soltysh deleted the soltysh:deprecate_config branch Feb 6, 2020
@cfergeau cfergeau mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton

@deads2k deads2k

Assignees

@sallyom sallyom

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@soltysh @sallyom @openshift-ci-robot @openshift-bot @openshift-merge-robot
You can’t perform that action at this time.