Use transactional_session_maker in the celery tasks #3901

abompard · 2020-01-10T15:16:18Z

This ensures that DB sessions are removed when the task is done.

abompard · 2020-01-14T10:08:18Z

I'm unable to reproduce locally the failures that CI sees. I'll keep working on this, sorry for the delay.


        Use transactional_session_maker in the celery tasks

This ensures that DB sessions are removed when the task is done. Signed-off-by: Aurélien Bompard <aurelien@bompard.org>


        Improve some mocks in the tasks unit tests

Also, we don't actually need to check that time.sleep is called. Signed-off-by: Aurélien Bompard <aurelien@bompard.org>

abompard requested a review from fedora-infra/bodhi as a code owner Jan 10, 2020

abompard force-pushed the abompard:tasks-transactions branch from 9f38ce7 to b7d8899 Jan 10, 2020

abompard mentioned this pull request Jan 10, 2020

Take precautions to avoid DB transaction leaks #3894

Closed

abompard force-pushed the abompard:tasks-transactions branch from b7d8899 to 73d9a93 Jan 13, 2020

abompard force-pushed the abompard:tasks-transactions branch 3 times, most recently from 3ee66d9 to ff69ed3 Jan 14, 2020

abompard added 2 commits Jan 8, 2020

abompard force-pushed the abompard:tasks-transactions branch from ff69ed3 to a8dca53 Jan 14, 2020

cverna approved these changes Jan 14, 2020

View changes

fedora-infra / bodhi