Skip to content

/ sops

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using version-based tags for Docker Images in Docker hub #542

Open
tschaible opened this issue Sep 30, 2019 · 6 comments
Open

Consider using version-based tags for Docker Images in Docker hub #542

tschaible opened this issue Sep 30, 2019 · 6 comments
Assignees
@imskr
Labels
Priority - Low easy enhancement help wanted

Comments

@tschaible
Copy link

@tschaible tschaible commented Sep 30, 2019

Currently, it appears the only tags pushed to Dockerhub are the latest tag and the git commit sha.

For example, when the newest 3.4.0 image was tagged, it was tagged as

It's often useful to have more meaningful tags created that match the actual version. With the latest 3.4.0 release it would preferred that it also be tagged with the version. So the following docker tags.

Additionally, it's not to have simplified major/minor tags. So the ideal set of tags would be
@ajvb
Copy link
Member

@ajvb ajvb commented Oct 11, 2019

I like this idea and it should be easy to add.

We'll get to it when we can, but if someone else want's to work on it you'll find the dockerhub upload code in here: https://github.com/mozilla/sops/blob/master/.circleci/config.yml
@imskr
Copy link

@imskr imskr commented Oct 20, 2019

I would like to work on this. Please assign
@imskr
Copy link

@imskr imskr commented Oct 21, 2019 •
edited

@ajvb should I make changes in https://github.com/mozilla/sops/blob/master/.circleci/config.yml
@ajvb
Copy link
Member

@ajvb ajvb commented Oct 21, 2019

@imskr yep!
@imskr imskr mentioned this issue Oct 23, 2019
Closed
eddiewebb added a commit to eddiewebb/sops that referenced this issue Jan 15, 2020
@eddiewebb
Added version to docker tag mozilla#542
66095f1 
This change accesses the environment variable CIRCLE_TAG

It also changes the docker image to `cimg` which is our new type that should be saller and faster over time, but that's unrelated, just grooming
@eddiewebb eddiewebb mentioned this issue Jan 15, 2020
Merged
eddiewebb added a commit to eddiewebb/sops that referenced this issue Jan 16, 2020
@eddiewebb
Added version to docker tag mozilla#542, using existing tag scheme
Loading status checks…
b113ebc
@eddiewebb
Copy link

@eddiewebb eddiewebb commented Jan 16, 2020

@ajvb / @imskr - I threw an updated circle config in #607 matching the needs of this issue. I noted some options in the PR description. Happy to tweak it further, but I noticed you are using tags in this repo and that seemed the easiest way to get at version to use in docker push.
ajvb added a commit that referenced this issue Jan 23, 2020
@ajvb
Merge pull request #607 from eddiewebb/circleci-tag
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
db9c552 
Added version to docker tag #542
@ajvb
Copy link
Member

@ajvb ajvb commented Jan 23, 2020

Fixed with #607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imskr imskr

Labels
Priority - Low easy enhancement help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

version-based tags for Docker Images in Docker hub
4 participants
@tschaible @ajvb @eddiewebb @imskr
You can’t perform that action at this time.