Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

?committer search option doesn't work #3648

Open
zdroid opened this issue Dec 7, 2019 · 13 comments
Open

?committer search option doesn't work #3648

zdroid opened this issue Dec 7, 2019 · 13 comments
Labels

Comments

@zdroid
Copy link
Member

@zdroid zdroid commented Dec 7, 2019

From COMMUNITY-ROLES.md:

Specifically: once a repository collaborator has merged at least 10 PRs (see https://github.com/tldr-pages/tldr/commits?committer=<username>) and submitted at least 5 non-trivial reviews to PRs (see https://github.com/tldr-pages/tldr/pulls?q=reviewed-by:<username>), which can overlap with the 10 they merged themselves, they should be invited to become a member of the tldr-pages organization.

The syntax provided for committer search, i.e. https://github.com/tldr-pages/tldr/commits?committer=<username> doesn't work. The information about committer exists in GitHub API, but it doesn't contain any reference to GitHub username. Do we replace it with some other wording?

@agnivade
Copy link
Member

@agnivade agnivade commented Dec 9, 2019

Woops, it should be author, not committer. Good catch @zdroid ! Would you like to open a PR to fix this ?

@zdroid
Copy link
Member Author

@zdroid zdroid commented Dec 9, 2019

@agnivade I will, but author doesn't show the commits merged by you.

@agnivade
Copy link
Member

@agnivade agnivade commented Dec 9, 2019

That's true actually. I don't know of any option that shows merged_by users offhand.

@sbrl
Copy link
Member

@sbrl sbrl commented Dec 9, 2019

I use something like this myself:

https://github.com/tldr-pages/tldr/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3A{{username}}
@zdroid
Copy link
Member Author

@zdroid zdroid commented Dec 9, 2019

@sbrl But again, that shows only the PRs made by you, not the ones merged by you.

@sbrl
Copy link
Member

@sbrl sbrl commented Dec 11, 2019

Ah, I misread what you were saying I thought you were talking about the opened 5 PRs one.

@zdroid
Copy link
Member Author

@zdroid zdroid commented May 2, 2020

This is an even bigger problem now, as GitHub often obscures such information. I suggest the requirement for that role being changed into non-trivial review of 10 PRs.

@sbrl
Copy link
Member

@sbrl sbrl commented May 3, 2020

Hrm. It might be worth implementing a script that determines how many merged PRs each person has.

@zdroid
Copy link
Member Author

@zdroid zdroid commented May 4, 2020

@sbrl Isn't it much easier to just see 10, 15 or 20 non-trivial PR reviews?

cc @agnivade

@agnivade
Copy link
Member

@agnivade agnivade commented May 4, 2020

I think both are important. Making reviews and writing the pages by themselves. It is the same in a normal codebase where a person should have submitted enough code first to get access. Reviews come after that IMO.

Writing a page from scratch requires you to think about the command, what options are important, in what order to write them and what examples are appropriate. It is good to be in those shoes to get an overall idea of the entire process. It also enables one to make better reviews because one has an idea of the background thinking required to write a page.

@zdroid
Copy link
Member Author

@zdroid zdroid commented May 4, 2020

@agnivade we are talking about "once a repository collaborator has merged at least 10 PRs", not the one before (about having your own PRs merged).

@agnivade
Copy link
Member

@agnivade agnivade commented May 4, 2020

Ah my bad. Yes, I don't see any big downsides of it.

@zdroid
Copy link
Member Author

@zdroid zdroid commented May 4, 2020

@agnivade downsides of what exactly? What would you suggest to replace the obviously not present option ?committer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.