Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upconncheck: allow to disable via config #1052
Merged
Conversation
julienschmidt
changed the title
Merged
|
I am not good at English, but I feel "liveness" is commonly used in context of healthcheck. |
|
Both seems to be used. E.g. Kubernetes uses "Liveness", in Red Hat Enterprise Virtualization "Liveliness" is used. |
|
@methane PTAL |
|
I just pushed another minimal change, where I just fixed two occurrences of the word liveness in the description of the DSN param to be lower-cased. |
tz70s
added a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
* conncheck: allow to disable via config * dsn: refactor writing of params in FormatDSN
tz70s
added a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
* conncheck: allow to disable via config * dsn: refactor writing of params in FormatDSN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
Add an option to disable the conncheck introduced in #934 via config / DSN. The default is to perform this liveliness check of connections on supported platforms, if not explicitly disabled.
Fixes #996
Checklist