Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
exclude GIT_SSL_NO_VERIFY env variable from getting stripped #1293
Conversation
|
that's actually kinda terrifying -- doesn't this variable expose you to all sorts of malicious MITM? I'm looking into why windows CI is failing -- I suspect a bad azure pipelines release :( |
|
I've opened https://github.com/microsoft/azure-pipelines-image-generation/issues/1468 for the |
|
Yeah, a bit yes. The proxy itself is pretty restricting and only allows connections to a handful of public domains such as github.com - and it does verify certs. So it's only a matter of trusting the path to the proxy inside the company network ... |
|
change seems fine (though scary!), I'll merge after fixing CI |
|
this has been released as part of v2.0.0 -- thanks again for the patch! |
Can this change please get merged? We sit behind a proxy that messes with certificates...