Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samplingRate does not affect isosurfaces #342

Closed
StasJ opened this issue Jul 31, 2019 · 4 comments
Closed

samplingRate does not affect isosurfaces #342

StasJ opened this issue Jul 31, 2019 · 4 comments

Comments

@StasJ
Copy link

@StasJ StasJ commented Jul 31, 2019

Unstructured Volume

uns

Structured Volume

str

Notice the jagged edged and misses caused by low sampling rate. Sometimes whole chunks will be missing. "samplingRate" has no effect.

@timrowley
Copy link
Contributor

@timrowley timrowley commented Aug 2, 2019

Hi. Sorry for the delay getting back to you. Volume rendering is undergoing large changes in OSPRay 2. I'm working on the unstructured volumes and we are working on sampling improvements for these. From the issues you've been filing it appears you have some interesting unstructured datasets. Would it be possible to share any of them with us for internal testing? Thanks!

@paulmelis
Copy link

@paulmelis paulmelis commented Aug 5, 2019

Is the v2 API with respect to volumes currently in flux as well? For example, parameters gradientShadingEnabled, singleShade and adaptiveSampling all seem to be missing from the code, preIntegration is now a parameter on the transfer function instead of the volume, etc.

@StasJ
Copy link
Author

@StasJ StasJ commented Aug 6, 2019

@timrowley I have some unstructured datasets I can gladly share with you, however I cannot post them publicly. Please let me know where I should contact you by email.

@jeffamstutz
Copy link
Contributor

@jeffamstutz jeffamstutz commented Jan 22, 2020

All sampling rate concerns are now a renderer parameter and intentionally do not affect isosurfaces, as isosurface intersection is now entirely Open VKL's job. We have made improvements with VKL's isosurfacing code, so testing again on OSPRay v2.0 should show improvements.

Pinging @gregjohnson here for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.