Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly use collections.abc #7692

Closed
bmw opened this issue Jan 16, 2020 · 2 comments
Closed

Properly use collections.abc #7692

bmw opened this issue Jan 16, 2020 · 2 comments

Comments

@bmw
Copy link
Member

@bmw bmw commented Jan 16, 2020

Python 3.9 is planning on enforcing that abstract base classes in the collections module are imported from collections.abc. See https://docs.python.org/3/library/collections.html#module-collections.

We currently are not always doing this in Certbot and are ignoring the deprecation warning about it at

ignore:.*collections\.abc:DeprecationWarning

Properly testing and finding all occurrences of this problem is a little tricky (see #7691), but we should fix this and remove the pytest.ini entry well before Python 3.9 is released.

@hugovk hugovk mentioned this issue Jan 22, 2020
2 of 2 tasks complete
@hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 22, 2020

Please see PR #7707.

About testing: it's now possible to add 3.9-dev (or nightly) to Travis CI, which point to 3.9 alpha, but dependent html5lib doesn't yet support 3.9 due to a similar collections.abc issue.

It was fixed in Oct 2018 (html5lib/html5lib-python#403) but we're still waiting for a release (html5lib/html5lib-python#419).

@bmw bmw added the has pr label Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.