Skip to content

/ electron

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument type for setVibrancy is missing nullability #20269

Open
Eugeny opened this issue Sep 18, 2019 · 0 comments
Open

Argument type for setVibrancy is missing nullability #20269

Eugeny opened this issue Sep 18, 2019 · 0 comments
Labels
documentation 📓

Comments

@Eugeny
Copy link

@Eugeny Eugeny commented Sep 18, 2019

The typings file specifies:

setVibrancy(type: 'appearance-based' | 'light' | 'dark' | 'titlebar' | 'selection' | 'menu' | 'popover' | 'sidebar' | 'medium-light' | 'ultra-dark'): void;

whereas docs suggest that passing null disables vibrancy.

The argument type should be nullable
@codebytere codebytere mentioned this issue Sep 18, 2019
Closed
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation 📓
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Eugeny @sofianguy
You can’t perform that action at this time.