Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up-
Microsoft
- Nagoya, Japan
- Sign in to view email
Pinned
1,411 contributions in the last year
Contribution activity
May 2020
Created a pull request in electron/electron that received 6 comments
fix: do not destroy thread in UI thread
Description of Change Destroying a thread implies joining it, and it should not be done in UI thread, otherwise it would cause assertions when DCHE…
+136
−111
•
6
comments
- test: fix flaky beforeunload tests
- test: multiple processes may crash in crashReporter test
- fix: read GTK dark theme setting on Linux
- docs: errors in isolated world are not dispatched to foreign worlds
- test: disable parallel/test-worker-sharedarraybuffer-from-worker-thread
- fix: make sure hunspell dict file is not destroyed in UI thread
- fix: do not destroy thread in UI thread
- fix: do not destroy thread in UI thread
- chore: cherry-pick 67864c214770 from Chromium
- chore: cherry-pick 67864c214770 from Chromium
- chore: cherry-pick 67864c214770 from Chromium
- chore: cherry-pick e89fe66d0473 from usrsctp
- chore: cherry-pick e89fe66d0473 from usrsctp
- chore: cherry-pick e89fe66d0473 from usrsctp
- test: hide child windows in webview spec
- fix: don't run environment bootstrapper
- fix: trigger about panel for about role on win
- refactor: improve MoveItemToTrash error description
- fix: nativeImage remote serialization
- test: bind to 127.0.0.1 in contextBridge spec
- build: save mksnapshot args in Windows mksnapshot.zip
- test: fix multiple connections in inspector test
- docs: remove note about experimental nature of sandbox
- test: add retries to another beforeunload test
- test: retry beforeunload test
- test: run tests under asan on linux-x64
- chore: cherry-pick 1288aa12369e from angle
- test: skip remote module related tests when enable_remote_module = false
- fix: exclude crashpad_handler binary on linux
- test: remove usage of the remote module from tests
- refactor: improve MoveItemToTrash error description
- refactor: ginify BrowserView
- feat: allow compressing crash uploads on linux
- refactor: tsify net module
- test: fix conditions for some tests
- chore: look harder for a commit's pull request.
- feat: add app render-process-gone event
- refactor: ginify Session
- feat: expose the desktopCapturer module in the main process
- Some pull request reviews not shown.
Created an issue in microsoft/ProjectReunion that received 4 comments
Question: Code for WinUI/Win32 template apps
I'm very interested to see how WinUI 3 is used with C++/Win32, but currently in order to see the actual code I have to install a preview version of…
4
comments