Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: make CI faster, magic contained within #21086
Merged
Conversation
MarshallOfSound
changed the title
This comment has been minimized.
This comment has been minimized.
|
Hm, looks like there's a double-build going on due to my size reduction logic. Will fix it up tomorrow. |
…fore zipping
MarshallOfSound
force-pushed the
idk-this-was-johns-idea
branch
from
6d81491
to
fda4b25
MarshallOfSound
force-pushed the
idk-this-was-johns-idea
branch
from
93548f0
to
fa10ec4
MarshallOfSound
force-pushed the
idk-this-was-johns-idea
branch
from
fa10ec4
to
9f9895b
MarshallOfSound
force-pushed the
idk-this-was-johns-idea
branch
from
403cc09
to
cdb575e
MarshallOfSound
force-pushed the
idk-this-was-johns-idea
branch
3 times, most recently
from
b0d25e1
to
8781c70
MarshallOfSound
force-pushed the
idk-this-was-johns-idea
branch
from
8781c70
to
ad866c3
…headers on macOS
This comment has been minimized.
This comment has been minimized.
|
Ok I got this working. I could explain how it works but I'm using a bunch of new tricks in here that would be quite a write up.
|
|
LGTM. Excellent work @MarshallOfSound!!!! |
| @@ -684,10 +694,18 @@ step-maybe-restore-git-cache: &step-maybe-restore-git-cache | |||
| paths: | |||
| - ~/.gclient-cache | |||
| keys: | |||
| - v2-gclient-cache-{{ arch }}-{{ checksum "src/electron/.circle-sync-done" }}-{{ checksum "src/electron/DEPS" }} | |||
| - v2-gclient-cache-{{ arch }}-{{ checksum "src/electron/.circle-sync-done" }} | |||
| - v2-gclient-cache-{{ checksum "src/electron/.circle-sync-done" }}-{{ checksum "src/electron/DEPS" }} | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
MarshallOfSound
Nov 28, 2019
Author
Member
Because it's just a git blob, not arch specific. Also we checkout macos on a linux machine anyway
| "//tools/v8_context_snapshot:v8_context_snapshot_generator", | ||
| ":licenses", | ||
| ] | ||
| data_deps = mksnapshot_deps |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
MarshallOfSound
merged commit 01f5e9c
into
master
16 of 18 checks passed
16 of 18 checks passed
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
Nov 28, 2019
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MarshallOfSound commentedNov 12, 2019
•
edited
So I tried a lot of things here, mostly based off of the idea @jkleinsc had around caching and restoring the out directory. On linux that works really well, on macOS the network speed is lower (appears to be only gigabit) so we have to make trade offs around out size vs cache upload / download time.
I think I found the sweet spot. Raising this PR for👀 now, I just reset the cache keys so the first run on this PR will be the old slow path. The second run will be ultra-fast.
Build time estimates are:
Linux ~13 minutes from start to tests complete
macOS ~28 minutes from start to tests complete
Notes: no-notes