Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upchore: upgrade ts generator for better type safety #20975
Merged
Conversation
MarshallOfSound
merged commit fcee721
into
master
12 of 15 checks passed
12 of 15 checks passed
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
Nov 5, 2019
|
No Release Notes |
This comment has been minimized.
This comment has been minimized.
|
/trop run backport |
This comment has been minimized.
This comment has been minimized.
|
The backport process for this PR has been manually initiated, here we go! :D |
This comment has been minimized.
This comment has been minimized.
|
I was unable to backport this PR to "7-1-x" cleanly; |
This comment has been minimized.
This comment has been minimized.
|
I have automatically backported this PR to "8-x-y", please check out #20976 |
MarshallOfSound
added a commit
that referenced
this pull request
Nov 5, 2019
* chore: upgrade ts generator for better type safety * spec: fix tests
This comment has been minimized.
This comment has been minimized.
|
@MarshallOfSound has manually backported this PR to "7-1-x", please check out #20977 |
trop
bot
added
in-flight/7-1-x
merged/8-x-y
and removed
needs-manual-bp/7-1-x
in-flight/8-x-y
labels
MarshallOfSound
added a commit
that referenced
this pull request
Nov 5, 2019
* chore: upgrade ts generator for better type safety * spec: fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MarshallOfSound commentedNov 5, 2019
Fixes a
// FIXMEin the ts generator that I kinda left unfixed.Notes: no-notes