Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix contract for one_to_n proxy and remove wrong check on startup #5551
Conversation
czepluch
force-pushed the
czepluch:one_to_n_startup_check
branch
from
b165d36
to
e9d4bb4
|
Thank you for fixing this. Not sure why this wasn't caught by the smoketests but i'll check this first thing tomorrow. |
|
LGTM |
remove unused imports
rakanalh
force-pushed the
czepluch:one_to_n_startup_check
branch
from
e9d4bb4
to
01c238c
Codecov Report
@@ Coverage Diff @@
## develop #5551 +/- ##
===========================================
- Coverage 80.95% 80.82% -0.13%
===========================================
Files 132 132
Lines 15025 15023 -2
Branches 2302 2302
===========================================
- Hits 12164 12143 -21
- Misses 2210 2223 +13
- Partials 651 657 +6
Continue to review full report at Codecov.
|
rakanalh
force-pushed the
czepluch:one_to_n_startup_check
branch
from
a58c20b
to
2218f46
|
@rakanalh unit test for the rpc endpoint still fails after your fix |
Apparently, there is a difference in how scheme is determined between
3.7.6 and prior versions:
```
Python 3.7.0 (default, Jan 20 2019, 18:10:09)
[GCC 8.2.1 20181127] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from urllib.parse import urlparse
>>> urlparse("localhost:123123")
ParseResult(scheme='', netloc='', path='localhost:123123', params='', query='', fragment='')
```
```
Python 3.7.6 (default, Jan 1 2020, 15:20:08)
[GCC 9.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from urllib.parse import urlparse
>>> urlparse("127.0.0.1:123123")
ParseResult(scheme='127.0.0.1', netloc='', path='123123', params='', query='', fragment='')
```
According to the python documentation:
https://docs.python.org/3/library/urllib.parse.html
> Following the syntax specifications in RFC 1808, urlparse recognizes a
netloc only if it is properly introduced by ‘//’. Otherwise the input is
presumed to be a relative URL and thus to start with a path component.
rakanalh
force-pushed the
czepluch:one_to_n_startup_check
branch
from
2218f46
to
565cb17
rakanalh
merged commit 7bc8f75
into
raiden-network:develop
17 checks passed
17 checks passed
codecov/project
Absolute coverage decreased by -0.12% but relative coverage increased by +4.75% compared to c64cacf
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
Fixes: #5550
This PR removes a check during startup that looked for a token address from the one_to_n contract, but that contract doesn't have a token_address specified.
It also fixes the initial problem that was introduced by what seems to be a copy/paste bug where the one_to_n proxy used the contract ABI of the monitoring services.
I am not sure if this is the best fix for this problem, but it works as a temporary fix during christmas time so that the nightlies start running again. At least the scenarios and Raiden itself now run locally again.