Skip to content

bpo-38495: Updated functions.rst: Clearer *sep* and *end* defaults explanation #17062

Closed
Seluj78 wants to merge 2 commits into
python:masterfrom
Seluj78:patch-7
Closed

bpo-38495: Updated functions.rst: Clearer *sep* and *end* defaults explanation #17062
Seluj78 wants to merge 2 commits into
python:masterfrom
Seluj78:patch-7

Conversation

@Seluj78
Copy link
Copy Markdown
Contributor

@Seluj78 Seluj78 commented Nov 5, 2019

@Seluj78
Copy link
Copy Markdown
Contributor Author

Seluj78 commented Nov 5, 2019

cc @vstinner

@Seluj78 Seluj78 changed the title Updated functions.rst: Clearer *sep* and *end* defaults explanation bpo-38495: Updated functions.rst: Clearer *sep* and *end* defaults explanation Nov 5, 2019
@Seluj78
Copy link
Copy Markdown
Contributor Author

Seluj78 commented Nov 5, 2019

@bedevere-bot updated title for issue number

Removed trailing whitespace
@Seluj78
Copy link
Copy Markdown
Contributor Author

Seluj78 commented Nov 5, 2019

ping @JulienPalard for review

@taleinat
Copy link
Copy Markdown
Contributor

@Seluj78, I've seen you ping/CC specific core devs on several recent PRs. Please avoid doing so unless they've specifically asked you to.

Core devs can make sure they're notified on changes to specific files. If they haven't done so, they probably don't want to be actively pinged on every such change.

@taleinat
Copy link
Copy Markdown
Contributor

That being said, @Seluj78, your enthusiasm and efforts to help improve Python are greatly appreciated! Please be patient with regard to our limited ability to address the many issues and PRs.

@Seluj78
Copy link
Copy Markdown
Contributor Author

Seluj78 commented Nov 18, 2019

@Seluj78, I've seen you ping/CC specific core devs on several recent PRs. Please avoid doing so unless they've specifically asked you to.

For Victor Stinner and Julien Palard, I know them very well (not an excuse, just a note) and they've told me that I could 😄

@taleinat
Copy link
Copy Markdown
Contributor

Ah, @Seluj78, that's fine then 👍

@vstinner
Copy link
Copy Markdown
Member

For Victor Stinner and Julien Palard, I know them very well (not an excuse, just a note) and they've told me that I could smile

I confirm. But I only plan to quickly approve trivial doc fixes like typos, and let others review more complex ones :-) FYI Jules and Julien are actively working together on the french documentation translation, that's how they spot so many tiny doc issues ;-)

@Seluj78
Copy link
Copy Markdown
Contributor Author

Seluj78 commented Nov 19, 2019

FYI Jules and Julien are actively working together on the french documentation translation, that's how they spot so many tiny doc issues ;-)

We're not the only one ! Proudly introducing @deronnax and @awecx 🤗 ❤️

Comment thread Doc/library/functions.rst
Print *objects* to the text stream *file* (the standard output by default),
separated by *sep* (a space by default) and followed by *end*
(a newline by default).
*sep*, *end*, *file* and *flush*, if present, must be given as keyword arguments.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a Python expert, I dislike such redundant documentation: the default value is already documented on the " .. function:: print(*objects, sep=' ', end='\n', file=sys.stdout, flush=False)" line. Moreover, this line ("*objects, " part) also explains that these parameters are keyword-only (cannot be passed as positional arguments).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand where you're coming from, I personally feel it's clearer that way

Also I followed your advice when you told me to look into bugs.python.org for doc bugs and I did, it's on you 😉

@vstinner
Copy link
Copy Markdown
Member

As a Python expert, ...

I mean that it's just my opinion. I have no idea if developers learning Python would prefer to have such "redundant" documentaiton. But it may be more expensive to maintain if we change the default values.

@csabella
Copy link
Copy Markdown
Contributor

I don't think this PR should be accepted. The ticket on the bug tracker seemed more for the idea that the OP couldn't see the space in sep in Sphinx more than a need to explain the defaults more. As Victor said, this is redundant and doesn't add much (if any) value.

-1 from me.

@vstinner vstinner closed this Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants