Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-37860: Add netlify deploy preview for docs #15288
bpo-37860: Add netlify deploy preview for docs #15288
Changes from all commits
2c1724aebf24e15312c6f80a6bbf74825337458e2aa75c02824f3a203e8f9bd73c2b39706382c087a79df5b228031fc12dFile filter...
Jump to…
willingcAug 21, 2019
Contributor
@Mariatta Do you think that this should be pinned or float upward?
epicfaaceAug 21, 2019
•
edited
Author
Contributor
I pinned it because that's how it was in .travis.yml.
https://github.com/python/cpython/blob/master/.travis.yml#L58
Actually, do you think it might be better to make .travis.yml to read from Doc/requirements.txt instead of specifying its own versions?
willingcAug 21, 2019
Contributor
Let's do this. Keep it pinned for now but add a comment:
# Pin sphinx to version specified in .travis.ymlon the line above Sphinx in requirements.txtepicfaaceAug 21, 2019
•
edited
Author
Contributor
Done. I think it might be better to just include
python -m pip install -r Docs/requirements.txtin.travis.ymlthough, so that we don't have to keep two files in sync, unless there's a reason not to do so?willingcAug 21, 2019
Contributor
@epicfaace For now, the least disruptive change was to make the modification here. Ideally, there wouldn't be duplication. Would you like to open an issue suggesting the above.
merwokAug 22, 2019
Member
Could this be specified in netlify.toml too instead of a special-purpose file?
epicfaaceAug 22, 2019
Author
Contributor
Nope. https://www.netlify.com/docs/build-settings