Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding the example program files that go along with the python-sqlite… #94
Conversation
…-sqlalchemy article
| @@ -1,4 +1,5 @@ | |||
| import queue | |||
| from builtins import range | |||
This comment has been minimized.
This comment has been minimized.
dbader
Jan 2, 2020
Member
Looks like this change is unrelated to the python-sqlite-sqlalchemy article—do we need it or is it accidental?
This comment has been minimized.
This comment has been minimized.
|
@writeson Had a couple of comments but otherwise your PR looks good & is ready to merge once these comments are resolved :) Happy New Year! @dbader Thanks Dan, hopefully have worked things out. I also re-arranged the directory structure as running the code broke when I moved it from my repository to materials. Hope you and your family had a wonderful holiday and are looking forward to the new year! |
|
Looks good Doug! Ready to merge from my perspective :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
writeson commentedJan 1, 2020
…-sqlalchemy article
Where to put new files:
my-awesome-articleHow to merge your changes: