Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect typespecs/docs for Posion.decode/2 and Parser.parse/2 #142

Open
mgartner opened this issue Aug 13, 2017 · 1 comment
Open

Incorrect typespecs/docs for Posion.decode/2 and Parser.parse/2 #142

mgartner opened this issue Aug 13, 2017 · 1 comment

Comments

@mgartner
Copy link

@mgartner mgartner commented Aug 13, 2017

Version: 3.1.0

It looks like {:error, :invalid, integer} is a valid return type for both Poison.decode/2 and Parser.parser/2, but neither type spec reflects this.

Here is where a tuple of that type is possibly returned:

Notice the typespecs of Poison.decode/2 and Parser.parser/2 do not include this type:

I noticed this when {:error, :invalid, 0} was returned by Poison.decode/2 in our production app.

@ConnorRigby
Copy link

@ConnorRigby ConnorRigby commented Jun 11, 2018

I've also noticed this. Any word?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.