Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 40 million developers.
Sign up
- San Francisco
- Sign in to view email
Pinned
720 contributions in the last year
Contribution activity
January 2020
Created a pull request in alainmarcel/UHDM that received 1 comment
Created an issue in alainmarcel/UHDM that received 4 comments
Headers don't include what they use
Looking at a random header, e.g. headers/variables.h: it does not include any headers, yet it uses SymbolFactory::getSymbol() for instance.
So the …
4
comments
- Most classes have a get_vpiParent(). Does it make sense to put this in some base class ?
- The hand-written classes should have documentation
- Generate dot file
- SymbolFactory internalization identifier should be its own type
- Pointers to other things: can they be const ?
- Object parameters should not be by value but reference
- Can the #defienes be an enumeration ?
- Overridden methods: let's make them 'override' or 'final'
- Generated code uses singletons
- get-methods should return a const reference
- No generated code should not be included