Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix "operator =" warning from tolua #4360
Comments
This comment has been minimized.
This comment has been minimized.
|
This can be closed. |
This comment has been minimized.
This comment has been minimized.
|
Not sure. The one warning itself has been fixed, but if it ever comes back, the cryptic message is there again with no help whatsoever about where the warning comes from. |
This comment has been minimized.
This comment has been minimized.
|
I took a look at this. The code of all files is put into a single variable, therefore without bigger changes it would not be possible to get the file and the line number that causes the warning. It would be possible to print the code that and make it more obvious. Would that be enough? |
This comment has been minimized.
This comment has been minimized.
|
The parser should be able to tell the class name, that would be absolutely helpful. |
This comment has been minimized.
This comment has been minimized.
|
Are this changes okay? Example output:
|
This comment has been minimized.
This comment has been minimized.
|
Almost, the output is exactly what I'm after, but it should still go through the |
This comment has been minimized.
This comment has been minimized.
|
Switched to using warning. I used a local variable to build the output together. The function warning would print out two newlines for every line. |
This comment has been minimized.
This comment has been minimized.
|
Still need to upgrade the tolua subrepo in here... |
When building, the tolua generator outputs the following warning:
Fix the cause of the warning (trying to export
operator =to Lua).Ideally, add an output to the tolua warning so that it's easier to identify the offending C++ code.