Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aar file type to gitignore #3233

Merged
merged 1 commit into from Nov 17, 2019

Conversation

@MichalDanielDobrzanski
Copy link
Contributor

@MichalDanielDobrzanski MichalDanielDobrzanski commented Nov 10, 2019

Instead of regular APK, we can build AAR that are library modules. They are similar to the APK, but they are used by them as dependency modules that contain resources.

Link:

https://developer.android.com/studio/projects/android-library

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Nov 17, 2019

@shiftkey shiftkey merged commit 1c11457 into github:master Nov 17, 2019
friederbluemle added a commit to friederbluemle/gitignore that referenced this pull request Dec 6, 2019
This reverts commit 1c11457.
@friederbluemle
Copy link
Contributor

@friederbluemle friederbluemle commented Dec 6, 2019

TBH, I'm not sure if the link in the description provides enough evidence for this change...

In fact, some people might have to add aar files to the default app/libs directory. If aar files are excluded by default, they won't show up in git status.

On the other hand, if you're talking about build output, then those files are contained in the build/ folder - which is already part of this .gitignore, meaning there is no real value in adding *.aar. This (amongst many other things) is taken care of in #2402

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Dec 9, 2019

@friederbluemle thanks for the feedback. @MichalDanielDobrzanski do you agree with this?

@MichalDanielDobrzanski
Copy link
Contributor Author

@MichalDanielDobrzanski MichalDanielDobrzanski commented Dec 10, 2019

I agree that some aar files land in libs folder.

However, the usual flow does not assume adding to Git compiled dependencies (due to their size or specific versioning). They are downloaded by default and checked out from VCS.

We can revert this, though.

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Dec 10, 2019

We can revert this, though.

I have no strong feelings either way on this, so I'll leave it up to @friederbluemle and @MichalDanielDobrzanski to figure this out and submit a follow-up PR (if necessary).

@friederbluemle
Copy link
Contributor

@friederbluemle friederbluemle commented Dec 10, 2019

Yes, also agree with @MichalDanielDobrzanski that compiled dependencies should normally not be added to version control. Normally these files are all contained in build/ (which is already ignored). So we can revert this. It is already taken care of in #2402 - @shiftkey please take a look. And @MichalDanielDobrzanski as well, in case there is anything to add. Thanks!!

tokuhira added a commit to tokuhira/gitignore that referenced this pull request Dec 16, 2019
friederbluemle added a commit to friederbluemle/gitignore that referenced this pull request Jan 10, 2020
This reverts commit 1c11457.
EffingFancy added a commit to EffingFancy/gitignore that referenced this pull request Feb 23, 2020
friederbluemle added a commit to friederbluemle/gitignore that referenced this pull request Mar 9, 2020
This reverts commit 1c11457.
r2pgl added a commit to r2pgl/gitignore that referenced this pull request Mar 15, 2020
friederbluemle added a commit to friederbluemle/gitignore that referenced this pull request Apr 21, 2020
This reverts commit 1c11457.
friederbluemle added a commit to friederbluemle/gitignore that referenced this pull request Aug 22, 2020
This reverts commit 1c11457.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants