Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix some bug risks and code quality issues #118
Merged
Conversation
Changes: - Use set comprehension instead of calling `set()` on an iterable in `src/sqlfluff/rules/std.py` and `test/linter_test.py` - Use `.values()` to iterate over the values of a dictionary in `src/sqlfluff/templaters.py` - Use identity test, `is`, for comparing types in `src/sqlfluff/parser/segments_base.py` - Simplify `if` expression in `src/sqlfluff/cli/commands.py` Also added a `.deepsource.toml` configuration file to run continuous static analysis on the repository with DeepSource.
|
@alanmcruickshank I ran analysis on my own fork of sqlfluff. You can see the issues here. |
codecov
bot
commented
Jan 15, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 22 22
Lines 2963 2963
=======================================
Hits 2677 2677
Misses 286 286
Continue to review full report at Codecov.
|
|
thanks for this @sanketsaurav! I'll check it out. |
alanmcruickshank
merged commit 5d5c1a9
into
alanmcruickshank:master
8 checks passed
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sanketsaurav commentedJan 15, 2020
Changes:
set()on an iterable insrc/sqlfluff/rules/std.pyandtest/linter_test.py.values()to iterate over the values of a dictionary insrc/sqlfluff/templaters.pyis, for comparing types insrc/sqlfluff/parser/segments_base.pyifexpression insrc/sqlfluff/cli/commands.pyThis PR also adds
.deepsource.tomlto run static analysis continuously on the repo with DeepSource. Upon enabling DeepSource, static analysis will be run on every PR to detect 500+ types of issues in the changes — including bug risks, anti-patterns, security vulnerabilities, etc.DeepSource is free to use for open-source projects, and is used by teams at NASA, Uber, Slack among many others, and open-source projects like ThoughtWorks/Gauge, Masonite Framework, etc.
To enable DeepSource analysis after merging this PR, please follow these steps:
You can also look at the docs for more details. Do let me know if I can be of any help!
Cheers,
Sanket
Founder, DeepSource