Skip to content

/ lichess-db

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgn dump initial fen instead of [FEN "?"] #17

Merged
merged 2 commits into from Jan 1, 2020
Merged

pgn dump initial fen instead of [FEN "?"] #17

merged 2 commits into from Jan 1, 2020

Conversation

@niklasf
Copy link
Contributor

@niklasf niklasf commented Jan 1, 2020 •
edited

Addressing https://lichess.org/forum/lichess-feedback/interesting-bug-or-just-a-documentation-typo--please-check-it-mate-#2: initialFen == None does not mean the initial position is unknown ("?").

(same as ornicar/lila@5664096)
niklasf and others added 2 commits Jan 1, 2020
@niklasf
pgn dump initial fen instead of [FEN "?"]
d854be7
@ornicar
syntax tweak
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9a0e4d4
@ornicar ornicar merged commit 69e5d0d into ornicar:master Jan 1, 2020
@ornicar
Copy link
Owner

@ornicar ornicar commented Jan 1, 2020

too bad 12/19 has already been exported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@niklasf @ornicar
You can’t perform that action at this time.