Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd regex to validate the correct format of CUIT #181
Closed
Conversation
|
Hi @eamanu, Thanks for your patch. I've only added the checking of the first two digits and not the checking for the place of the dashes. These kind of separators are generally ignored in python-stdnum because for a lot of numbers their placement is not very well defined. I've merged your change as 0b30c4b and also ensured that the correct exception is raised (InvalidComponent). |
|
@arthurdejong thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
eamanu commentedJan 6, 2020
According to #179 not any (2 digits) prefix are accepted on
argentinian CUIT. So I added an Regex to validate
correctly the CUIT's format.