Issue 39323: Add test for imghdr cli

classification

Title:	Add test for imghdr cli
Type:	enhancement	Stage:	patch review
Components:	Tests	Versions:	Python 3.9, Python 3.8, Python 3.7

process

Status:	open	Resolution:
Dependencies:		Superseder:
Assigned To:		Nosy List:	xtreak
Priority:	normal	Keywords:	patch

Created on 2020-01-13 16:42 by xtreak, last changed 2020-01-13 18:33 by xtreak.

Pull Requests
URL	Status	Linked	Edit
PR 17993	open	xtreak, 2020-01-13 18:33

Messages (1)
msg359919 - (view)	Author: Karthikeyan Singaravelan (xtreak) *	Date: 2020-01-13 16:42
imghdr module has a cli that can display the image type for a given filename and also recurse through directories. I would like to propose following changes : * Add tests for the imghdr cli. * The cli uses hardcoded '/' separator in the end for directories this is a minor issue with windows where the separators are \ and the last separator is displayed with / like c:\Foo\Bar\Spam/ . Using os.sep can be a better option here. I have a PR that I will add shortly for review.

msg359919 - (view)

Author: Karthikeyan Singaravelan (xtreak) * (Python committer)

Date: 2020-01-13 16:42

imghdr module has a cli that can display the image type for a given filename and also recurse through directories. I would like to propose following changes :

* Add tests for the imghdr cli.
* The cli uses hardcoded '/' separator in the end for directories this is a minor issue with windows where the separators are \ and the last separator is displayed with / like c:\Foo\Bar\Spam/ . Using os.sep can be a better option here.

I have a PR that I will add shortly for review.

History
Date	User	Action	Args
2020-01-13 18:33:14	xtreak	set	keywords: + patch stage: patch review pull_requests: + pull_request17396
2020-01-13 16:42:19	xtreak	create