Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixing validation display on Create Repository dialog #2308
+23
−20
Conversation
StanleyGoldman
requested a review
from jcansdale
Mar 29, 2019
StanleyGoldman
added
the
Ready for Review
label
Mar 29, 2019
StanleyGoldman
added some commits
Apr 5, 2019
jcansdale
reviewed
Apr 5, 2019
| @@ -107,17 +107,21 @@ | |||
| Grid.Column="1" | |||
| MaxLength="{x:Static ghfvs:Constants.MaxRepositoryNameLength}" | |||
| Text="{Binding RepositoryName, UpdateSourceTrigger=PropertyChanged}" | |||
| SpellCheck.IsEnabled="True" | |||
This comment has been minimized.
This comment has been minimized.
jcansdale
Apr 5, 2019
Collaborator
It looks like spell checking has been disabled. Was this by design?
This comment has been minimized.
This comment has been minimized.
StanleyGoldman
Apr 5, 2019
Author
Contributor
Yea, I disabled it, when I couldn't type VisualStudio without it calling that an error, I decided that it was not useful...
This comment has been minimized.
This comment has been minimized.
jcansdale
Apr 5, 2019
Collaborator
Lol, makes sense. Though I'm perfectly capable of misspelling the name of my repo.
This comment has been minimized.
This comment has been minimized.
jcansdale
Apr 5, 2019
Collaborator
It look like dotcom also has spell checking disabled fro this field.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Added screenshots |
jcansdale
merged commit 56c347b
into
master
Apr 5, 2019
jcansdale
deleted the
fixes/repository-creation-view-errors
branch
Apr 5, 2019
meaghanlewis
referenced this pull request
Apr 5, 2019
Closed
Development Sprint: April 8 release #2240
StanleyGoldman
added
the
bug
label
Apr 11, 2019
StanleyGoldman
changed the title
Fixing validation on create repository dialog
Fixing validation display on Create Repository dialog
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
StanleyGoldman commentedMar 29, 2019
•
edited
Related #2264
Depends on: