Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository context doesn't change after clone if solution already open #2003

Closed
jcansdale opened this issue Oct 22, 2018 · 2 comments
Closed

Repository context doesn't change after clone if solution already open #2003

jcansdale opened this issue Oct 22, 2018 · 2 comments
Assignees
@jcansdale
Labels
bug
Milestone
2.5.9

Comments

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Oct 22, 2018 •
edited

Version

  • GitHub Extension for Visual Studio version: v2.5.8
  • Visual Studio version: 2017

What happened

Steps to Reproduce

  1. Open a solution
  2. Open Clone dialog
  3. Clone a repository
  4. Team Explorer pane becomes visible and clone progress is shown
  5. Repository doesn't change when clone completes

Expected behavior:

Repository should change when clone completes.

If the current solution has unsaved changed, a dialog should appear with the option to save changes or ignore (the same as when user opens a new solution).

Actual behavior:

Repository only changes (consistently?) when there is no solution / folder already open. This works fine on Visual Studio 2015.
@jcansdale jcansdale added the bug label Oct 22, 2018
@jcansdale jcansdale self-assigned this Oct 22, 2018
@jcansdale jcansdale mentioned this issue Oct 22, 2018
Merged
@grokys
Copy link
Contributor

@grokys grokys commented Oct 22, 2018

What should happen if a solution is open with unsaved changes?
@jcansdale
Copy link
Collaborator Author

@jcansdale jcansdale commented Oct 22, 2018

@grokys A dialog should appear with the option to save changes or ignore. I'll add that the the expected behavior.
@grokys grokys added this to Medium Priority in BUGS Oct 24, 2018
@grokys grokys closed this in #2004 Oct 25, 2018
BUGS automation moved this from Medium Priority to Done Oct 25, 2018
@meaghanlewis meaghanlewis changed the title Repository context doesn't change after clone if solution already olpen Repository context doesn't change after clone if solution already open Oct 29, 2018
@meaghanlewis meaghanlewis added this to the 2.5.9 milestone Oct 29, 2018
@sguthals sguthals mentioned this issue Nov 1, 2018
Closed
@meaghanlewis meaghanlewis mentioned this issue Nov 1, 2018
Closed
@meaghanlewis meaghanlewis removed this from Done in BUGS Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcansdale jcansdale

Labels
bug
Projects
None yet
Milestone
2.5.9
Linked pull requests

Successfully merging a pull request may close this issue.

Explicitly open repository when clone completes
3 participants
@grokys @meaghanlewis @jcansdale
You can’t perform that action at this time.