Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keras documentation inaccuracy #13584

Open
maor121 opened this issue Nov 26, 2019 · 0 comments
Open

Keras documentation inaccuracy #13584

maor121 opened this issue Nov 26, 2019 · 0 comments
Labels

Comments

@maor121
Copy link

@maor121 maor121 commented Nov 26, 2019

Small thing, but costed me several hours to find :)
In the documentation example of Siamese mnist .

We see a code for contrastive loss, based on a paper. But the labels in this function are reversed from
the paper. Meaning in the paper Y=0 if X1,X2 are from same domain, Y=1 otherwise. In the code example in the documentation it is reversed.

The code example quote the paper, so I thought it might be confusing :)

My suggestion is to change the function to match the paper, and also change the code to use the reverse labels (reverse the 0 and 1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.