Skip to content

/ pygrep-hooks

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect single backticks at the start of the line #24

Merged
merged 5 commits into from Jan 11, 2020
Merged

Detect single backticks at the start of the line #24

merged 5 commits into from Jan 11, 2020

Conversation

@mik-laj
Copy link
Contributor

@mik-laj mik-laj commented Jan 11, 2020

Hello

I am working on the Apache Airflow project and one hook did not detect one error, so I am sending the patch.
Screenshot 2020-01-11 at 18 04 56

Best regards,
Kamil
@mik-laj
Detect single backticks at the start of the line
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
15ad92d
@asottile
Copy link
Member

@asottile asottile commented Jan 11, 2020

awesome -- thanks for the patch! can you add a quick test to https://github.com/pre-commit/pygrep-hooks/blob/master/tests/hooks_test.py demoing this change?
@mik-laj
Add tests
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0b4dd28
@mik-laj
Copy link
Contributor Author

@mik-laj mik-laj commented Jan 11, 2020

@asottile i added tests.
@asottile
asottile reviewed Jan 11, 2020
View changes
tests/hooks_test.py Outdated
r" `JPdzQ2QqF_AQl=t]`",
r" `97P}j:' :MJhH,JnFCVlE\"pX cM/j6!s:=69Wf>Yc[5mb9z)W?Hb5m{Lt,)f,&x<mr'C3NBDMnr6<'|-b6`>",
r" `@ ~7JyWy/V9V<th:}y.#``S",
r" `- 3]1f{I**4Q).6}/#BrEPW.2^v]4n6oia8Xu_fOgh:q_E9Qxp}n:p T)*EId99,[7w^&AX(uQ_7~$)DX*z=t].qLh+ON>sMOt}`",

This comment has been minimized.

Sign in to view
@asottile

asottile Jan 11, 2020
Member

I'm not interested in this test, please remove it -- tests should be obvious from reading what they are testing -- this one is nonsense

This comment has been minimized.

Sign in to view
@mik-laj

mik-laj Jan 11, 2020
Author Contributor

Removed
mik-laj added 3 commits Jan 11, 2020
@mik-laj
Remove fuzzy tests
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
52cde84
@mik-laj
Use single quote characters
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b659c9e
@mik-laj
Add new line
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f02b5c4
@asottile
asottile approved these changes Jan 11, 2020
View changes
Copy link
Member

@asottile asottile left a comment

@asottile asottile merged commit 1f48caa into pre-commit:master Jan 11, 2020
1 check passed
1 check passed
pre-commit.pygrep-hooks #20200111.5 succeeded
Details
@asottile
Copy link
Member

@asottile asottile commented Jan 11, 2020

thanks! this has been released as v1.4.4 🎉
@mik-laj
Copy link
Contributor Author

@mik-laj mik-laj commented Jan 11, 2020

What is the ETA for v1.4.4? I would like to update in my project.
@asottile
Copy link
Member

@asottile asottile commented Jan 11, 2020

negative four minutes ;)
@mik-laj mik-laj mentioned this pull request Jan 11, 2020
Merged
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@mik-laj @asottile
You can’t perform that action at this time.