Skip to content

/ testify

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert value order comparison. #710

Open
alexpantyukhin opened this issue Dec 27, 2018 · 2 comments
Open

Assert value order comparison. #710

alexpantyukhin opened this issue Dec 27, 2018 · 2 comments
Labels
good first issue help wanted

Comments

@alexpantyukhin
Copy link
Contributor

@alexpantyukhin alexpantyukhin commented Dec 27, 2018

I have created a test collection comparisons there https://github.com/alexpantyukhin/assertord . I believe many of them are redundant but it's just for demo. Any thoughts could it be good idea to integrate that functionality into the testify? Also I guess it would be good to have assert.IsGreater, assert.IsGreaterOrEqual, assert.IsLess, assert.IsLessOrEqual in the testify.
@alexpantyukhin alexpantyukhin mentioned this issue Jan 5, 2019
Merged
@alexpantyukhin

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@alexpantyukhin alexpantyukhin commented Jan 6, 2019

@georgelesica-wf I have added values comparison in this #713 PR . Could you please review?
@dmirogin

This comment has been minimized.

Sign in to view
Copy link

@dmirogin dmirogin commented Jul 16, 2019

This issue can be closed because of #713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@alexpantyukhin @dmirogin @georgelesica-wf
You can’t perform that action at this time.