➜

This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to log in and link your GitHub username to your profile.
For more information, see this post about the migration.

classification
Title: Dead assignment in pyinit_config
Type: performance Stage: resolved
Components: Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: alex.henrie, benjamin.peterson
Priority: normal Keywords: patch

Created on 2020-01-08 18:11 by alex.henrie, last changed 2020-01-09 02:47 by benjamin.peterson. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 17907 merged alex.henrie, 2020-01-08 18:13
Messages (2)
msg359619 - (view) Author: Alex Henrie (alex.henrie) * Date: 2020-01-08 18:11 
The function pyinit_config currently contains the following line:

    config = &tstate->interp->config;

However, the config variable is not used after that point.

Victor Stinner has confirmed that this assignment is unnecessary: https://github.com/python/cpython/pull/16267/files#r364216184
msg359648 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2020-01-09 02:47 
New changeset 2c7ed417a4c758f1c3f97fcbca70a49f79e58c07 by Benjamin Peterson (Alex Henrie) in branch 'master':
closes bpo-39261: Remove dead assignment from pyinit_config. (GH-17907)
https://github.com/python/cpython/commit/2c7ed417a4c758f1c3f97fcbca70a49f79e58c07
History
Date User Action Args
2020-01-09 02:47:01benjamin.petersonsetstatus: open -> closed

nosy: + benjamin.peterson
messages: + msg359648

resolution: fixed
stage: patch review -> resolved
2020-01-08 18:21:09alex.henriesettype: performance
2020-01-08 18:19:49alex.henriesetversions: + Python 3.9
2020-01-08 18:13:25alex.henriesetkeywords: + patch
stage: patch review
pull_requests: + pull_request17318
2020-01-08 18:11:55alex.henriecreate