➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2020-01-09 04:14 by alex.henrie, last changed 2020-01-09 09:14 by vstinner. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 17914 | merged | alex.henrie, 2020-01-09 04:17 | |
| Messages (2) | |||
|---|---|---|---|
| msg359652 - (view) | Author: Alex Henrie (alex.henrie) * | Date: 2020-01-09 04:14 | |
config_init_module_search_paths currently has the following code:
const wchar_t *p = sys_path;
while (1) {
p = wcschr(sys_path, delim);
The first assignment to p is unnecessary because it is immediately overwritten. Victor Stinner suggested moving the variable declaration into the loop itself to clarify that it does not need to be initialized elsewhere: https://github.com/python/cpython/pull/16267/files#r364216448
|
|||
| msg359659 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2020-01-09 09:14 | |
New changeset f3e5e9566989635225d1b91088888074fc260817 by Victor Stinner (Alex Henrie) in branch 'master': bpo-39270: Remove dead assignment from config_init_module_search_paths (GH-17914) https://github.com/python/cpython/commit/f3e5e9566989635225d1b91088888074fc260817 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2020-01-09 09:14:32 | vstinner | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2020-01-09 09:14:15 | vstinner | set | nosy:
+ vstinner messages: + msg359659 |
| 2020-01-09 04:17:04 | alex.henrie | set | keywords:
+ patch stage: patch review pull_requests: + pull_request17326 |
| 2020-01-09 04:14:48 | alex.henrie | create | |