Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add writing direction to locale files #33556

Closed
wants to merge 2 commits into from
Closed

Add writing direction to locale files #33556

wants to merge 2 commits into from
+8,297 −2,484

Conversation

@doom777
Copy link
Contributor

doom777 commented Nov 3, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Locale files do not contain writing direction

What is the new behavior?

Locale files will contain writing direction

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Look at first commit for actual changes. Second commit is just generated locale files
@doom777 doom777 requested review from angular/dev-infra-framework as code owners Nov 3, 2019
@googlebot googlebot added the cla: yes label Nov 3, 2019
@doom777 doom777 requested a review from angular/fw-core as a code owner Nov 3, 2019
@doom777

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

doom777 commented Nov 3, 2019

If you're wondering the purpose of this PR, it is to eventually support angular/angular-cli#16047
Currently, creating an RTL locale build does not make the page RTL
@petebacondarwin
petebacondarwin requested changes Nov 4, 2019
View changes
Copy link
Member

petebacondarwin left a comment

Thanks for this PR - generally looks good. A couple of items to look at.
We should also consider whether this should land before or after #33523 as they clearly conflict with each other.

I think also that since we are well into the RC now, and this has a public API change, then this will probably go into 9.1.0
packages/common/src/i18n/locale_data_api.ts Show resolved Hide resolved
packages/common/src/i18n/locale_data_api.ts Outdated Show resolved Hide resolved
tools/gulp-tasks/cldr/extract.js Outdated Show resolved Hide resolved
packages/common/src/i18n/locale_data_api.ts Outdated Show resolved Hide resolved
@doom777

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

doom777 commented Nov 4, 2019

@petebacondarwin do you suggest I rebase this change on top of #33523?
@petebacondarwin

This comment has been minimized.

Sign in to view
Copy link
Member

petebacondarwin commented Nov 4, 2019

Let's hold off for 24 hours while we work out what release this could go in and what to do about that other PR. Cheers
@petebacondarwin
petebacondarwin approved these changes Nov 4, 2019
View changes
@ngbot ngbot bot modified the milestone: needsTriage Nov 4, 2019
@petebacondarwin

This comment has been minimized.

Sign in to view
Copy link
Member

petebacondarwin commented Nov 4, 2019

I've marked this as target: master only as I think it might have to go into 9.1.x.
@IgorMinar do you have a view?
@petebacondarwin petebacondarwin self-assigned this Nov 4, 2019
@josephperrott
josephperrott approved these changes Nov 4, 2019
View changes
Copy link
Member

josephperrott left a comment

LGTM, for dev-infra
@doom777

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

doom777 commented Nov 5, 2019 •
edited

I noticed that #33523 was merged in. I guess I'll rebase this PR on top of master.
@petebacondarwin

This comment has been minimized.

Sign in to view
Copy link
Member

petebacondarwin commented Nov 6, 2019

Thanks @doom777 - sorry I didn't get back to you earlier.
@petebacondarwin

This comment has been minimized.

Sign in to view
Copy link
Member

petebacondarwin commented Nov 6, 2019

This is now competing with #33584 since they will also conflict :-/
@doom777

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

doom777 commented Nov 6, 2019 •
edited

@petebacondarwin true, but my PR was here first ;-)
Also, this PR is further ahead of the other one, since we got more approvals, and are merged with master.
Also, if you really insist, I can rebase this PR on top of that one also.

Edit: they are also merged with #33523
@petebacondarwin

This comment has been minimized.

Sign in to view
Copy link
Member

petebacondarwin commented Nov 6, 2019

The question is really whether this can go into master & patch (e.g. 9.0.0) or only master (e.g. 9.1.0), since it is arguably a new public API and we are now in RC for 9.0.0. cc @IgorMinar / @kara ?
@doom777

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

doom777 commented Nov 6, 2019

@petebacondarwin BTW, why are these locale files checked into source control? Why not generate them during the build process?
@petebacondarwin

This comment has been minimized.

Sign in to view
Copy link
Member

petebacondarwin commented Nov 6, 2019

That is a good question. It has been like this for many years.
I think it is nice not to have to generate them locally when developing that Angular framework.

That being said we should look into ways to automate the update of these to some Bazel rules...
@josephperrott

This comment has been minimized.

Sign in to view
Copy link
Member

josephperrott commented Nov 6, 2019

This is actually an outstanding task for the @angular/dev-infra-framework team. To determine if continuing to store them in the repository is the best option or if they should be generated at build time. And with whichever method, how to best do that going forward.
@AndrewKushnir AndrewKushnir requested a review from IgorMinar Nov 6, 2019
@AndrewKushnir

This comment has been minimized.

Sign in to view
Copy link
Contributor

AndrewKushnir commented Nov 6, 2019

Adding @IgorMinar to reviewers list, since there are changes to public API that need to be reviewed/approved. @IgorMinar, could you please have a look at the first commit (where the API changes are)? Thank you.
@doom777

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

doom777 commented Nov 8, 2019

blocked by: #33682
@doom777

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

doom777 commented Nov 21, 2019

Hey, so we are in action:merge right now, so what else needs to be done?
@matsko

This comment has been minimized.

Sign in to view
Copy link
Member

matsko commented Nov 21, 2019

Sorry @doom777, the presubmits need to run again before merging. ETA 1-2 hours.
@matsko

This comment has been minimized.

Sign in to view
Copy link
Member

matsko commented Nov 21, 2019

presubmit = https://test.corp.google.com/ui#id=OCL:281825168:BASE:281825201:1574373305055:9a1b9da8

ivy-presubmit = https://tap.corp.google.com/ui#id=OCL:281825168:BASE:281825333:1574373342060:bf55f5c0
@IgorMinar
IgorMinar requested changes Nov 22, 2019
View changes
Copy link
Member

IgorMinar left a comment •
edited

Hi there, I rereviewed the PR again and noticed that getLocaleDirection is not reexported from @angular/core which means that the function is not available via the public api surface, rendering this feature inaccessible to developers (outside of our own unit tests).

Can you please update the PR with proper reexports, which will also trigger the need to update the public api guard (the CI failure will instruct you what command to run to do that).

While this PR is large, it should not conflict with other PRs, so we shouldn't rush to get it in because of a fear that it will bit rot. It's more important that we merge it in in a functional state.
@doom777 doom777 requested a review from angular/fw-public-api as a code owner Nov 22, 2019
@doom777

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

doom777 commented Nov 22, 2019

@IgorMinar Thanks for that note. I have updated the code. Please review it.
Of course you're correct that it's more important that the PR is functional, then just merged.
doom777 added 2 commits Nov 22, 2019
@doom777
feat: add direction property to locale files
Loading status checks…
4ac5ac5
@doom777
feat: update the locale files
Loading status checks…
e69890d
@doom777

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

doom777 commented Nov 25, 2019

Hey, @IgorMinar @petebacondarwin can this PR move forward?
@doom777

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

doom777 commented Nov 28, 2019

Hey guys, just another ping on this PR.
@petebacondarwin

This comment has been minimized.

Sign in to view
Copy link
Member

petebacondarwin commented Nov 28, 2019

I'm afraid it is Thanksgiving in US - so it is unlikely anything will move on this before Tuesday.
@doom777

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

doom777 commented Dec 3, 2019

Hey, everyone. It's Tuesday here. Just pinging.
@IgorMinar
IgorMinar approved these changes Dec 3, 2019
View changes
Copy link
Member

IgorMinar left a comment

Lgtm now. Thank you for making all the follow up changes.
@IgorMinar

This comment has been minimized.

Sign in to view
Copy link
Member

IgorMinar commented Dec 3, 2019 •
edited

merge-assistance: global approval & caretaker can you please run presubmit?
@mhevery

This comment has been minimized.

Sign in to view
Copy link
Member

mhevery commented Dec 3, 2019

presubmit
@mhevery mhevery closed this in 3c24384 Dec 3, 2019
mhevery added a commit that referenced this pull request Dec 3, 2019
@doom777 @mhevery
feat: update the locale files (#33556)
Loading status checks…
15d3e74 
PR Close #33556
mhevery referenced this pull request Dec 11, 2019
@mhevery
Revert "fix(common): update closure locales to include directionality…
Loading status checks…
1183075 
… data (#34240)"

This reverts commit a02bde7.
@angular-automatic-lock-bot

This comment has been minimized.

Sign in to view
Copy link

angular-automatic-lock-bot bot commented Jan 3, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin

@IgorMinar IgorMinar

@josephperrott josephperrott

@angular/fw-core fw-core

Assignees

@petebacondarwin petebacondarwin

Labels
PR action: merge PR action: merge-assistance PR action: presubmit PR target: master-only cla: yes comp: i18n type: feature
Projects
None yet
Milestone
  needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@doom777 @petebacondarwin @josephperrott @AndrewKushnir @IgorMinar @mhevery @matsko @googlebot
You can’t perform that action at this time.