Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump year #27880

Closed
wants to merge 5 commits into
base: master
from

Conversation

@CaerusKaru
Copy link
Member

CaerusKaru commented Jan 1, 2019

Happy New Year 🎉

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 1, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no label Jan 1, 2019

@CaerusKaru CaerusKaru force-pushed the CaerusKaru:adam/year branch from f465056 to 5ab406b Jan 1, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 1, 2019

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 1, 2019

@CaerusKaru CaerusKaru force-pushed the CaerusKaru:adam/year branch 2 times, most recently from 6ab3528 to 4d26d4c Jan 1, 2019

@sarunint

This comment has been minimized.

Copy link
Contributor

sarunint commented Jan 1, 2019

Happy New Year to you too! 🎉🎉🎉

@ngbot ngbot bot added this to the needsTriage milestone Jan 4, 2019

@CaerusKaru CaerusKaru force-pushed the CaerusKaru:adam/year branch from 4d26d4c to 0baafc9 Jan 6, 2019

@CaerusKaru CaerusKaru requested review from IgorMinar and angular/docs-infra as code owners Jan 6, 2019

@CaerusKaru CaerusKaru force-pushed the CaerusKaru:adam/year branch 2 times, most recently from 1a4ab2b to 3e9a243 Jan 8, 2019

@CaerusKaru CaerusKaru requested review from angular/fw-docs-marketing as code owners Jan 8, 2019

@CaerusKaru CaerusKaru force-pushed the CaerusKaru:adam/year branch from 3e9a243 to 133e8d6 Jan 8, 2019

@kyliau

kyliau approved these changes Jan 11, 2019

@IgorMinar IgorMinar removed the cla: no label Jan 11, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 11, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

</p>
<!-- TODO: twitter widget (but only on pages that use twitter) -->
<p>
Super-powered by Google ©2010-2019.

This comment has been minimized.

@alfaproject

alfaproject Jan 11, 2019

Contributor

lol

@IgorMinar

This comment has been minimized.

Copy link
Member

IgorMinar commented Jan 11, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 11, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Jan 11, 2019

@IgorMinar IgorMinar added cla: yes and removed cla: no labels Jan 11, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 11, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@IgorMinar

This comment has been minimized.

Copy link
Member

IgorMinar commented Jan 11, 2019

caretaker: no g3 impact

@gkalpak
Copy link
Member

gkalpak left a comment

OOC, @IgorMinar, why the different copyright notices? We have:

@IgorMinar

This comment has been minimized.

Copy link
Member

IgorMinar commented Jan 11, 2019

Oh George, I'm really disappointed that you didn't notice that there is one more:

* @license
* Copyright Google Inc. All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license

dang! You found that one as well! How can you be this awesome?!? You are incredible! 🙇

I tried to decrease the number of copyright notices with dates to absolute minimum (it's not truly required by the copyright law, but the interpretation of the law is a bit fuzzy, so we are keeping years in the main license files). So the first type is used only in the main license file and in the angular.io footer.

The second one is what I generally used everywhere, except for source code because I really don't want to touch hundreds if not thousands of files as we are landing all the Ivy PRs.

The third one comes from CLI - it's a golden file showing what the cli generates. I don't have control over that in this repo.

And the last one is the one I thought you missed, but of course you didn't. It's the notice in all source files in the repo. We'll need to find a good time to update these without disrupting day-to-day development too much. (it might be easier than it seems because the diff would unlikely collide, but the change is definitely out of scope for this PR).

AndrewKushnir added a commit that referenced this pull request Jan 11, 2019

kyliau added a commit to kyliau/angular that referenced this pull request Jan 11, 2019

kyliau added a commit to kyliau/angular that referenced this pull request Jan 11, 2019

petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Jan 14, 2019

petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Jan 14, 2019

@CaerusKaru CaerusKaru referenced this pull request Jan 18, 2019

Closed

build: bump year #28220

wKoza added a commit to wKoza/angular that referenced this pull request Jan 18, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Jan 18, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Jan 18, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Jan 18, 2019

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.