Create fibonacci_sequence_dnc.py#1631
Closed
LeeJiHyeong wants to merge 5 commits intoTheAlgorithms:masterfrom
LeeJiHyeong:master
Closed
Create fibonacci_sequence_dnc.py#1631LeeJiHyeong wants to merge 5 commits intoTheAlgorithms:masterfrom LeeJiHyeong:master
LeeJiHyeong wants to merge 5 commits intoTheAlgorithms:masterfrom
LeeJiHyeong:master
Conversation
Find Fibonacci sequence quickly by divide and conquer
Find Fibonacci sequence quickly by divide and conquer
onlinejudge95
requested changes
Dec 12, 2019
| >>> get_fibonacci(10) | ||
| 55 | ||
| >>> get_fibonacci(20) | ||
| 6765 |
Collaborator
There was a problem hiding this comment.
Write a doctest for a case where n < 2, also what about n < 1 and n < 0
| return get_squared(matrix, n)[0][1] | ||
|
|
||
|
|
||
| def get_squared(matrix, n): |
Collaborator
There was a problem hiding this comment.
I am sorry if i was unclear, but you need to write doctests for all the methods/functions, taking into considerations all the cases i.e covering all the branches of your code.
Check this out for idea https://github.com/TheAlgorithms/Python/blob/master/data_structures/linked_list/circular_linked_list.py
onlinejudge95
added
awaiting changes
|
Stale pull request message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.