Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken author email; rename project to typed_ast (underscore!) #120

Merged
merged 1 commit into from Jun 4, 2019

Conversation

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jun 4, 2019

Fixes #115

Copy link
Collaborator

@msullivan msullivan left a comment

Will changing the name break downstream users?

@gvanrossum
Copy link
Member Author

@gvanrossum gvanrossum commented Jun 4, 2019

Will changing the name break downstream users?

Not for wheel users -- the wheels already are named typed_ast-*.

I dunno how to test this, but currently pip install --no-binary=all works with either typed-ast or typed_ast. On pypi, currently typed_ast redirects to typed-ast; I assume that after the change it will be the other way around. I'm not sure how to test further without risking a premature release. Post-release it should be easy to test and we can disable the release if it's broken.

@msullivan
Copy link
Collaborator

@msullivan msullivan commented Jun 4, 2019

@gvanrossum gvanrossum merged commit ea22233 into master Jun 4, 2019
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@gvanrossum gvanrossum deleted the fix-setup branch Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.