Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the monitored interface and (if available) name [enhancement] #37

Open
squatto opened this issue Dec 30, 2019 · 6 comments
Open

Display the monitored interface and (if available) name [enhancement] #37

squatto opened this issue Dec 30, 2019 · 6 comments

Comments

@squatto
Copy link

@squatto squatto commented Dec 30, 2019

It would be helpful if the UI showed the interface that's being monitored, and if possible, the name. This is especially useful when monitoring multiple interfaces at the same time.

e.g. on macOS I have these:

❯ networksetup -listallhardwareports

Hardware Port: Wi-Fi
Device: en0

Hardware Port: USB 10/100/1000 LAN
Device: en7

Maybe add it before the "Total Rate Up/Down" on the first line?

image

I would think that it would be preferred to be shown by default and not displayed through a command line switch.

If I had any experience with Rust I'd give it a go myself, but I unfortunately don't. I suspect that with the cross-platform nature of what it would require platform-specific processes to retrieve the interface name. However, given that the monitored interface (e.g. en0) is known, that could be displayed fairly easily?

Thanks!

@imsnif
Copy link
Owner

@imsnif imsnif commented Dec 30, 2019

I like the idea! We already show the interface name in the UI for each connection string, so we could definitely show either a specific interface near the "Total Rate" above (if using the -i flag), or "All Interfaces" (or some such) if not using -i.

@squatto
Copy link
Author

@squatto squatto commented Dec 30, 2019

@imsnif Excellent! I installed a Rust IDE and I'll see if this is something that I can tackle when I have a chance. Do you have a good Rust resource or two you can recommend?

@imsnif
Copy link
Owner

@imsnif imsnif commented Dec 30, 2019

I really liked The Book. Beware though, it can be a little overwhelming at times. :)

This part of the project is (mostly) well covered in tests, so cargo test can help you out - and the rust compiler is pretty amazing with its detailed error messages. So if you want to just dive in and hack a little after you get the basic syntax (and likely a primer on the borrow checker!) you might find some success there. Feel free to ping me with any questions, issues, or if you need a direction or ideas.

@captain-yossarian
Copy link
Contributor

@captain-yossarian captain-yossarian commented Mar 3, 2020

If somebody is interested to finish this PR, feel free to pick it up, because I have an issues with testing framework on my local machine

@captain-yossarian
Copy link
Contributor

@captain-yossarian captain-yossarian commented Aug 20, 2020

Hi, @imsnif .
Is this issue still relevant ? I'm happy to continue my work

@imsnif
Copy link
Owner

@imsnif imsnif commented Aug 21, 2020

Sure @captain-yossarian, that would be great :)

@imsnif imsnif assigned captain-yossarian and unassigned squatto Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.